Open
Conversation
JackMeadDev
approved these changes
May 26, 2023
Collaborator
JackMeadDev
left a comment
JackMeadDev
left a comment
There was a problem hiding this comment.
Nice work, you've got a really clean conversion here from Trello to Mongo, and I had no issues following the instructions to run your app with CosmosDB 😄 I've left a couple of optional thoughts, but very happy for you to merge whenever you're ready
|
|
||
| def change_card_status(card_id, status): | ||
| collection = get_collection() | ||
| collection.update_one({"_id": card_id}, {"$set": {"status": status}}) No newline at end of file |
Collaborator
There was a problem hiding this comment.
Minor, but it's a good habit to convert the string card_id here to an ObjectId (like below) since some versions of MongoDB will refuse to do the type conversion for you, although CosmosDB does
from bson import ObjectId
...
collection.update_one({"_id": ObjectId(card_id)}, {"$set": {"status": status}})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure you are raising this PR against your own repository and not the original. If it says https://github.com/CorndelWithSoftwire in the search bar right now, you are in the wrong place!
Please also don't forget to submit the PR's url to Aptem afterwards (by clicking on the corresponding exercise component, pasting the url in the textbox that appears and then pressing the finish button).